fix: correctly apply change profiles filter at pipeline#934
Open
bercianor wants to merge 4 commits into
Open
Conversation
dieppa
dismissed
their stale review
I think the @Profile annotation should be only at class-level. Allowing it also in the apply method is confusing. Some user may think, I can use @Profile in the apply method, but not in the rollback?
So I believe the right choice is in at class-level.
I push some changes. Pleas ereview if you think it's ok
dieppa
reviewed
Jun 26, 2026
Comment on lines
+76
to
+78
| if (applyMethod != null && applyMethod.isAnnotationPresent(Profile.class)) { | ||
| return filterProfiles(Arrays.asList(applyMethod.getAnnotation(Profile.class).value())); | ||
| } |
Member
There was a problem hiding this comment.
I think the @Profile annotation should be only at class-level. Allowing it also in the apply method is confusing. Some user may think, I can use @Profile in the apply method, but not in the rollback?
So I believe the right choice is in at class-level.
I push some changes. Please review and let me know your thoughts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.